WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
6241
Remove WebFrame's parent frame pointer, instead rely on WebCore's parent concept
https://bugs.webkit.org/show_bug.cgi?id=6241
Summary
Remove WebFrame's parent frame pointer, instead rely on WebCore's parent concept
Maciej Stachowiak
Reported
2005-12-25 17:13:25 PST
WebKit has a redundant frame tree which is not necessarily entirely consistent with the WebCore tree it duplicates. As part of removing it and pushing code down, WebFrame should no longer keep a direct parent pointer and should count on the one from WebCore.
Attachments
change to do it
(15.45 KB, patch)
2005-12-25 17:56 PST
,
Maciej Stachowiak
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1
2005-12-25 17:56:38 PST
Created
attachment 5280
[details]
change to do it
Geoffrey Garen
Comment 2
2005-12-25 21:45:55 PST
Comment on
attachment 5280
[details]
change to do it Looks good. I think these lines for (i = [_private->children count]-1; i >=0; i--) { [[_private->children objectAtIndex:i] _detachFromParent]; - [_private->children removeObjectAtIndex:i]; } now have braces that don't belong.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug