Bug 6241 - Remove WebFrame's parent frame pointer, instead rely on WebCore's parent concept
Summary: Remove WebFrame's parent frame pointer, instead rely on WebCore's parent concept
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-25 17:13 PST by Maciej Stachowiak
Modified: 2005-12-26 15:07 PST (History)
0 users

See Also:


Attachments
change to do it (15.45 KB, patch)
2005-12-25 17:56 PST, Maciej Stachowiak
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2005-12-25 17:13:25 PST
WebKit has a redundant frame tree which is not necessarily entirely consistent with the WebCore tree it 
duplicates. As part of removing it and pushing code down, WebFrame should no longer keep a direct 
parent pointer and should count on the one from WebCore.
Comment 1 Maciej Stachowiak 2005-12-25 17:56:38 PST
Created attachment 5280 [details]
change to do it
Comment 2 Geoffrey Garen 2005-12-25 21:45:55 PST
Comment on attachment 5280 [details]
change to do it

Looks good.

I think these lines

	 for (i = [_private->children count]-1; i >=0; i--) {
	     [[_private->children objectAtIndex:i] _detachFromParent];
-	     [_private->children removeObjectAtIndex:i];
	 }

now have braces that don't belong.