RESOLVED FIXED 6170
CSS1: Properties for :first-letter aren't recalculated on color change
https://bugs.webkit.org/show_bug.cgi?id=6170
Summary CSS1: Properties for :first-letter aren't recalculated on color change
Matthias Lange
Reported Tuesday, December 20, 2005 9:17:51 PM UTC
The color of :first-letter is rendered wrong in following elements if it was changed previously through another element. The attached test case demonstrates it: in the first paragraph the first letter is rendered blue, because it is contained in a <a href ... statement. However the first letter of the second paragraph should be black but it is blue.
Attachments
Test case for above filed bug (578 bytes, text/html)
2005-12-20 13:19 PST, Matthias Lange
no flags
First attempt (22.73 KB, patch)
2007-06-04 00:17 PDT, Rob Buis
hyatt: review-
Using Hyatt's approach (22.53 KB, patch)
2007-06-04 00:57 PDT, Rob Buis
hyatt: review+
Matthias Lange
Comment 1 Tuesday, December 20, 2005 9:19:01 PM UTC
Created attachment 5190 [details] Test case for above filed bug
Joost de Valk (AlthA)
Comment 2 Wednesday, December 21, 2005 9:14:47 PM UTC
Confirmed. Secondly, you are not able to select the first letter when it's styled differently, this is an issue too.
Matthias Lange
Comment 3 Thursday, December 22, 2005 11:39:12 PM UTC
(In reply to comment #2) > Confirmed. Secondly, you are not able to select the first letter when it's styled differently, this is an issue > too. What do you mean by selecting the first letter? Is this related to WebKit internals or to some CSS stuff?
Rob Buis
Comment 4 Monday, June 4, 2007 8:17:41 AM UTC
Created attachment 14849 [details] First attempt I am not 100% sure this is the right approach, but I can't think of another solution atm. Cheers, Rob.
Dave Hyatt
Comment 5 Monday, June 4, 2007 8:22:39 AM UTC
Comment on attachment 14849 [details] First attempt The unique() bit is for this purpose. Approach is basically right, but I'd rather you set the unique bit if it has first-letter (rather than adding first-letter to the canShareStyle check).
Rob Buis
Comment 6 Monday, June 4, 2007 8:57:31 AM UTC
Created attachment 14850 [details] Using Hyatt's approach I hope I picked the right place for this code :) Cheers, Rob.
Dave Hyatt
Comment 7 Monday, June 4, 2007 9:03:37 AM UTC
Comment on attachment 14850 [details] Using Hyatt's approach r=me
Rob Buis
Comment 8 Monday, June 4, 2007 9:15:57 AM UTC
Landed in r21964.
Note You need to log in before you can comment on or make changes to this bug.