WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
6138
QString should be sent to pasture and replaced by DOMString/DOMStringImpl
https://bugs.webkit.org/show_bug.cgi?id=6138
Summary
QString should be sent to pasture and replaced by DOMString/DOMStringImpl
Eric Seidel (no email)
Reported
2005-12-18 10:55:38 PST
QString should be sent to pasture and replaced by DOMString/DOMStringImpl I'm about 50% of the way through this in WebCore. I'm going to attach the patches in pieces as I get things back up and running.
Attachments
first patch, removing many uses of .qstring()
(92.77 KB, patch)
2005-12-22 19:50 PST
,
Eric Seidel (no email)
mjs
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2005-12-22 19:50:37 PST
Created
attachment 5234
[details]
first patch, removing many uses of .qstring()
Eric Seidel (no email)
Comment 2
2005-12-22 20:02:24 PST
Comment on
attachment 5234
[details]
first patch, removing many uses of .qstring() removes KWQLabel (unused) converts a bunch of QString to DOMString adds DOMString::replace(QChar,QChar) removes a bunch of .qstring() usage.
Maciej Stachowiak
Comment 3
2005-12-22 22:57:17 PST
Comment on
attachment 5234
[details]
first patch, removing many uses of .qstring() r=me assuming no performance regression and that layout tests pass.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug