RESOLVED FIXED 6106
DOMString should hold its impl in a RefPtr 
https://bugs.webkit.org/show_bug.cgi?id=6106
Summary DOMString should hold its impl in a RefPtr
Eric Seidel (no email)
Reported 2005-12-16 01:54:27 PST
DOMString should hold it's impl in a RefPtr Simplifies a bit of code. Patch attached.
Attachments
Proposed patch. (7.32 KB, patch)
2005-12-16 01:58 PST, Eric Seidel (no email) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-12-16 01:58:44 PST
Created attachment 5104 [details] Proposed patch. Also does a little cleanup.
Darin Adler
Comment 2 2005-12-16 07:30:45 PST
Comment on attachment 5104 [details] Proposed patch. A couple refinements you could do before landing: With this change, ~DOMString, DOMString(const DOMString &), and DOMString::operator= don't need to be explicitly declared or implemented. The default generated ones will do the right thing without any code. (The same would be true of the default constructor except that as I recall the default constructor is only generated if you don't delcare any others.) Also, you should replace tabs with spaces in these files (patches show many tabs).
Eric Seidel (no email)
Comment 3 2005-12-16 14:25:21 PST
I made darin's suggested fixes before landing.
Note You need to log in before you can comment on or make changes to this bug.