RESOLVED FIXED6052
WebKit+SVG fails to handle xlink:href on gradients 
https://bugs.webkit.org/show_bug.cgi?id=6052
Summary WebKit+SVG fails to handle xlink:href on gradients
Rob Buis
Reported 2005-12-12 11:30:46 PST
I see two misrendering svgs on this page, and both due to the same, likely gradient related, bug. Compare the svg and generated png, the differences are quite clear. Please fix :) Cheers, Rob.
Attachments
Reduced testcase (1.98 KB, image/svg+xml)
2005-12-13 03:26 PST, Rob Buis 		no flags
Details
Further reduction (504 bytes, image/svg+xml)
2005-12-13 03:39 PST, Eric Seidel (no email) 		no flags
Details
Simple patch (1.62 KB, patch)
2005-12-16 16:59 PST, Julien Palmas 		eric: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-12-12 11:33:52 PST
I believe this is related to the hackish way in which we currently do style resolution for <stop> elements. However, I see: 2005-12-12 11:26:15.712 Safari[25820] Warning, no gradient stops, gradient (0x13da4be4) will be all black! in the console, which indicates this might not be a style problem at all.
Rob Buis
Comment 2 2005-12-13 03:26:45 PST
Created attachment 5063 [details] Reduced testcase
Eric Seidel (no email)
Comment 3 2005-12-13 03:39:36 PST
Created attachment 5064 [details] Further reduction
Julien Palmas
Comment 4 2005-12-16 16:59:41 PST
Created attachment 5119 [details] Simple patch The referenced gradient (the one containing the stops) was never properly built (ie: addStop never called). Hense the gradient using xlink:href did not inherit any stop.
Ladd Van Tol
Comment 5 2005-12-17 13:54:09 PST
Rendering of gradients is much improved with this patch. Also fixes display (but not performance) of http://me.in-berlin.de/~darwin/svg/incoming/gearflowers.svg as referred to by 6060.
Darin Adler
Comment 6 2005-12-19 14:12:43 PST
Comment on attachment 5119 [details] Simple patch Patch looks fine. But there's no ChangeLog and no regression test -- we would like to have both of those.
Eric Seidel (no email)
Comment 7 2005-12-20 00:29:32 PST
Comment on attachment 5119 [details] Simple patch This works, but I think we can do this better by removing the whole resourceNotification() system all together. I have a patch for that and will post it. Thanks for such a great diagnosis!
Eric Seidel (no email)
Comment 8 2006-01-15 03:13:31 PST
This works again. Although it's still not a nice as it should be.
Note You need to log in before you can comment on or make changes to this bug.