Bug 6039 - Update KCanvasFiltersQuartz.mm to match style guidelines
Summary: Update KCanvasFiltersQuartz.mm to match style guidelines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-11 00:50 PST by Eric Seidel (no email)
Modified: 2005-12-12 09:25 PST (History)
1 user (show)

See Also:


Attachments
Code cleanup to match style guidelines (mostly spacing changes) (41.47 KB, patch)
2005-12-11 00:52 PST, Eric Seidel (no email)
darin: review+
Details | Formatted Diff | Diff
A version of the patch ignoring whitespace (17.81 KB, patch)
2005-12-11 00:53 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-12-11 00:50:50 PST
Update KCanvasFiltersQuartz.mm to match style guidelines

This is a simple patch (99% spacing changes) to make the kcanvas filter code closer match our style 
guidelines.

I also made one small fix of a leak of CIContexts under error conditions (we were exiting early from a 
method which later performed cleanup).
Comment 1 Eric Seidel (no email) 2005-12-11 00:52:36 PST
Created attachment 5025 [details]
Code cleanup to match style guidelines (mostly spacing changes)
Comment 2 Eric Seidel (no email) 2005-12-11 00:53:43 PST
Created attachment 5026 [details]
A version of the patch ignoring whitespace
Comment 3 Darin Adler 2005-12-11 17:09:30 PST
Comment on attachment 5025 [details]
Code cleanup to match style guidelines (mostly spacing changes)

+static QString KCPreviousFilterOutputName = QString("__previousOutput__");

The above should just be:

static QString KCPreviousFilterOutputName = "__previousOutput__";

r=me on this change

Reading this code I see lots to comment on that has nothing to do with what the
patch changes -- maybe as part of code review.
Comment 4 Eric Seidel (no email) 2005-12-12 09:25:01 PST
Oliver might hate me... hopefully this won't cause to many conflicts w/ his patches in progress.