Bug 5997 - REGRESSION: Focus rings around links are not erased when focus is lost
Summary: REGRESSION: Focus rings around links are not erased when focus is lost
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-07 22:30 PST by mitz
Modified: 2005-12-08 02:12 PST (History)
0 users

See Also:


Attachments
initialize m_inDetach to false (1.44 KB, patch)
2005-12-08 01:59 PST, mitz
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2005-12-07 22:30:25 PST
Focus rings around links use a blueish tint even when the Graphite appearance is selected in System 
Preferences. The focus ring is not always erased when focus moves on to another link or control.

To reproduce: in System Preferences > Appearance, select Graphite. In Safari Preferences > Advanced, 
deselect "Press Tab to highlight". Then on this page, or on http://bugzilla.opendarwin.org/enter_bug.cgi?
product=WebKit , press option-Tab repeatedly.
Comment 1 mitz 2005-12-07 22:49:04 PST
I think the different color is a feature.
Comment 2 mitz 2005-12-08 01:59:50 PST
Created attachment 4998 [details]
initialize m_inDetach to false
Comment 3 Eric Seidel (no email) 2005-12-08 02:03:35 PST
Comment on attachment 4998 [details]
initialize m_inDetach to false

Bah!  Another one!  Where is Valgrind when you need it.

Please remove the extra spaces before I review + this.	You can also submit the
patch with my name as the reviewer if you do so in the next 30 mins. :)
Comment 4 Eric Seidel (no email) 2005-12-08 02:04:51 PST
Comment on attachment 4998 [details]
initialize m_inDetach to false

Actually, I'll just land the damn thing and fix on land.