Bug 5974 – <foreignObject> is unimplemented

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Eric Seidel (no email)]

<foreignObject> is unimplemented

This would be trivial to implement (given our already working CDF support), I just haven't found the 
time.

To fix this, one would have to do the following:

1.  Implement a simple SVGForeignObjectElementImpl which returns a standard RenderBlock as its 
renderer.
2.  Find all the places in the code where SVGNames::foreignObjectTag has been commented out, and 
add those back.
3.  One may also need to exten the standard RenderBlock just a bit in order to have it support applying 
arbitrary filters or other svg specific properties (if those are required by the spec, you'll have to check).

[Eric Seidel (no email)]

This should be no harder than <text> which maciej just landed. ( http://bugzilla.opendarwin.org/
show_bug.cgi?id=4883 )

[Eric Seidel (no email)]

Created attachment 5641 [details]
Implements foreignObject (and makes a couple other fixes to related code)

[Eric Seidel (no email)]

Comment on attachment 5641 [details]
Implements foreignObject (and makes a couple other fixes to related code)

This is still woefully in need of some test cases.  But the patch works and
thus can stand for review now.

[Darin Adler]

Comment on attachment 5641 [details]
Implements foreignObject (and makes a couple other fixes to related code)

Do lines like this one:

+    totalTransform.invert().map((double)_x, (double)_y, &localX, &localY);

really need type casts?

Looks good, r=me.

[Eric Seidel (no email)]

Landed w/ a bunch of test cases.