Bug 5965 - feImage and image have Image loading race condition
Summary: feImage and image have Image loading race condition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-06 03:45 PST by Eric Seidel (no email)
Modified: 2006-01-12 00:34 PST (History)
2 users (show)

See Also:


Attachments
refactor <image> to use a RenderImage subclass for display and a HTMLImageLoader subclass for loading (25.51 KB, patch)
2006-01-11 22:52 PST, Alexander Kellett
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-12-06 03:45:47 PST
feImage and image have Image loading race condition

This should probably be solved by using a refactored version of HTMLImageLoader from the khtml side.  
<feImage> has an aditional issue in that it has no way currently to notify it's parent <filter> element that 
it's changed (once the image load is done) so as to allow the filter to notify all clients of that resource to 
tell them to repaint themselves.

Right now, if the images happen to load quickly enough, things display propertly... otherwise they don't.
Comment 1 Eric Seidel (no email) 2005-12-30 01:21:15 PST
Bumping this priority, since now everyone will be running into these, now that svg tests are turned on by 
default.  I may have to disable svg tests by default until we fix this.
Comment 2 Eric Seidel (no email) 2006-01-08 17:00:18 PST
These tests have been disabled until this bug is fixed:

svg/W3C-SVG-1.1/filters-light-01-f.svg-disabled
svg/W3C-SVG-1.1/filters-specular-01-f.svg-disabled
svg/W3C-SVG-1.1/render-groups-03-t.svg-disabled
Comment 3 Alexander Kellett 2006-01-11 22:52:37 PST
Created attachment 5612 [details]
refactor <image> to use a RenderImage subclass for display and a HTMLImageLoader subclass for loading
Comment 4 Eric Seidel (no email) 2006-01-12 00:29:13 PST
Comment on attachment 5612 [details]
refactor <image> to use a RenderImage subclass for display and a HTMLImageLoader subclass for loading

I had to make a couple tweaks when landing (mostly removing uncessary header
includes, a slight build fix, and a trivial copy/paste change from RenderPath
to fix filter and mask support with image rendering.)

Looks great though.  r=me.