WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
5964
Animation (<animateColor>, <animateTransform>, etc) are broken after DOM Merger
https://bugs.webkit.org/show_bug.cgi?id=5964
Summary
Animation (<animateColor>, <animateTransform>, etc) are broken after DOM Merger
Eric Seidel (no email)
Reported
2005-12-06 03:42:56 PST
Animation (<animateColor>, <animateTransform>, etc) are broken after DOM Merger I moved the KSVGTimeScheduler onto <svg> (which was wrong), and I'm also no longer using SVGDocumentImpl (and DocumentImpl doesnt' know how to kick off the timers, etc.) All these will have to be fixed to make animations work again.
Attachments
Makes animation work again.
(25.57 KB, patch)
2006-01-21 22:57 PST
,
Eric Seidel (no email)
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2006-01-21 22:57:34 PST
Created
attachment 5826
[details]
Makes animation work again. This patch makes <animateColor> work again. It stopped working because the timers were never started. During the DOM merger I moved much of the SVGDocumentImpl logic onto SVGSVGElementImpl in an effort not to modify DocumentImpl too much. Now I've created a SVGDocumentExtensions class to hold all of the SVGDocumentImpl specific goop. Eventually we'll create an HTMLDocumentExtensions class and that can hold all the HTML specific goop which is currently found in DocumentImpl.
Darin Adler
Comment 2
2006-01-22 10:28:47 PST
Comment on
attachment 5826
[details]
Makes animation work again. Looks good. r=me
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug