WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
VERIFIED FIXED
5921
Hit-testing text in overflows does not take scrolling into account
https://bugs.webkit.org/show_bug.cgi?id=5921
Summary
Hit-testing text in overflows does not take scrolling into account
mitz
Reported
2005-12-02 15:30:01 PST
When trying to select text that's a direct descendant of a block with overflow:auto or scroll, scrolling is ignored, so you end up selecting text above or to the left of where you're pointing or dragging. To reproduce, open the testcase, scroll each overflow down or to the right, and the drag across the text to make a selection. Note that this happens only with text that's directly inside the block with overflow (top two examples).
Attachments
testcase
(999 bytes, text/html)
2005-12-02 15:31 PST
,
mitz
no flags
Details
suggested patch
(6.96 KB, patch)
2005-12-02 23:49 PST
,
mitz
no flags
Details
Formatted Diff
Diff
suggested patch
(6.96 KB, patch)
2005-12-02 23:49 PST
,
mitz
darin
: review-
Details
Formatted Diff
Diff
revised patch
(7.07 KB, patch)
2005-12-03 09:58 PST
,
mitz
ggaren
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
mitz
Comment 1
2005-12-02 15:31:00 PST
Created
attachment 4912
[details]
testcase
Dave Hyatt
Comment 2
2005-12-02 17:26:01 PST
This is wrong in shipping Safari also, but it's differently wrong. :)
mitz
Comment 3
2005-12-02 23:49:37 PST
Created
attachment 4913
[details]
suggested patch
mitz
Comment 4
2005-12-02 23:49:38 PST
Created
attachment 4914
[details]
suggested patch
Darin Adler
Comment 5
2005-12-03 08:57:37 PST
Comment on
attachment 4914
[details]
suggested patch This looks like a really great fix to me. However, I think that containingBlock() can be a relatively complicated calculation, so it should be put in a local variable since we're using it three times in a row.
mitz
Comment 6
2005-12-03 09:58:17 PST
Created
attachment 4918
[details]
revised patch
mitz
Comment 7
2005-12-03 09:59:32 PST
Comment on
attachment 4918
[details]
revised patch Put containingBlock() into a local variable as Darin suggested.
Adele Peterson
Comment 8
2005-12-14 10:44:42 PST
I've committed this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug