Bug 5882 – disabled type="file" element doesn't appear disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Alexei Svitkine]

Other browsers support the disabling of input type="file" elements, either in the html directly 
( disabled="true" ) or with Javascript ( document.getElementById("file_input").disabled = true; ).

Neither the shipping nor the TOT version of WebKit handles either way properly, while all other browsers 
do.

See example with both Safari and other browsers at:
http://projectmagma.net/~myrdred/file_input.html

[Michael J. Cohen]

on r11976, the input type="file" element appears to be disabled functionally but does not appear 'greyed 
out'.

[Joost de Valk (AlthA)]

Seeing the same as MJC, changing subject, i will attached the testcase in the url to the bug itself.

[Joost de Valk (AlthA)]

Created attachment 6344 [details]
Testcase

[Rob Buis]

Created attachment 8264 [details]
proposed patch

My first attempt at fixing this. Be aware that I have zero objC experience :)
I can make a new patch including the given testcase if needed.
Cheers,

Rob.

[Eric Seidel (no email)]

Comment on attachment 8264 [details]
proposed patch

This needs a test case, but otherwise looks fine.

Test cases are especially important for this area of the code because Adele is about to re-write this control using the engine instead of AppKit. :)

[Rob Buis]

Created attachment 8270 [details]
Patch including testcase

[Darin Adler]

Comment on attachment 8270 [details]
Patch including testcase

Since this test is a manual test rather than an automatic one, it should be in WebCore/manual-tests rather than in LayoutTests.

[Rob Buis]

Created attachment 8278 [details]
Testcase now in manual tests

For your convenience, I moved the testcase :)
Cheers,

Rob.

[Alexey Proskuryakov]

(In reply to comment #8)
> For your convenience, I moved the testcase :)

But isn't it an automated test case, actually? :)

The original state is disabled, so a pixel test would catch the chage.

[Darin Adler]

Comment on attachment 8278 [details]
Testcase now in manual tests

Seems fine. This makes the file button look disabled. However, I think this does not disable all the relevant file button behavior. It's worth testing whether a disabled file button responds to clicks on the file name, drags, and other kinds of interaction that don't directly involve the "choose file" button.

Also, we may want to change the appearance to make the file icon and file name look disabled as well.

r=me

[Darin Adler]

(In reply to comment #9)
> But isn't it an automated test case, actually? :)
> 
> The original state is disabled, so a pixel test would catch the chage.

Oops. OK. Alexey right, me wrong, I guess we should land the version in LayoutTests.

[Darin Adler]

Committed revision 14370.