Bug 5878 - REGRESSION (WebTextRenderer.m r1.201): pointToOffset always takes the CG code path
Summary: REGRESSION (WebTextRenderer.m r1.201): pointToOffset always takes the CG code...
Status: VERIFIED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-29 08:57 PST by mitz
Modified: 2005-12-09 01:02 PST (History)
0 users

See Also:


Attachments
Add missing return (978 bytes, patch)
2005-11-29 09:07 PST, mitz
mjs: review+
Details | Formatted Diff | Diff
regression test (3.74 KB, patch)
2005-11-30 10:49 PST, mitz
no flags Details | Formatted Diff | Diff
expected result for pixel test (19.94 KB, image/png)
2005-11-30 10:50 PST, mitz
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2005-11-29 08:57:26 PST
WebTextRenderer.m:587:

    if (shouldUseATSU(run))
        ATSU_pointToOffset(self, run, style, x, includePartialGlyphs); // <---- "return" missing!
    return CG_pointToOffset(self, run, style, x, includePartialGlyphs);
Comment 1 mitz 2005-11-29 09:07:24 PST
Created attachment 4852 [details]
Add missing return
Comment 2 Maciej Stachowiak 2005-11-29 12:23:55 PST
Comment on attachment 4852 [details]
Add missing return

r=me
Comment 3 Eric Seidel (no email) 2005-11-29 18:56:59 PST
Is there a way to make a test case which would catch this?  For example clicking somewhere on ATSUI text 
and having the wrong text select?
Comment 4 mitz 2005-11-30 10:49:20 PST
Created attachment 4880 [details]
regression test
Comment 5 mitz 2005-11-30 10:50:47 PST
Created attachment 4881 [details]
expected result for pixel test