Bug 5854 – Please update build-webkit script to accept additional build arguments from command line

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Dan Wood]

Often, I want to build webkit with some additional parameters passed into xcodebuild, for instance, 
DEPLOYMENT_POSTPROCESSING=YES.

Currently, this does not seem reasonably easy to do; you have to modify the project files or the build-
webkit script.

If we could have additional parameters from the command line passed to xcodebuild, it would be possible 
without much hassle to vary the building process, to do useful things like strip symbols, build universal 
binary, change the install path, and so forth.

[Dan Wood]

MacDome says it's just a matter of adding @ARGV to the lines with xcodebuild ... can somebody confirm?

[Eric Seidel (no email)]

Created attachment 5393 [details]
fix.

[Dan Wood]

The patch seems to do the trick for me.  I built webkit as a fat, stripped binary using the following 
invocation:

build-webkit GCC_OPTIMIZATION_LEVEL=s ARCHS='ppc i386' SDKROOT=/Developer/SDKs/
MacOSX10.4u.sdk DEPLOYMENT_POSTPROCESSING=YES GCC_TREAT_WARNINGS_AS_ERRORS=NO

Being the probable only client for this fix (except for perhaps bdash), I'm satisfied with the patch.

[Darin Adler]

Comment on attachment 5393 [details]
fix.

What removes the "-svg" (or is it "--svg"?) if that is passed as an argument?

[Maciej Stachowiak]

Moving to r- until Darin's comment is addressed.

[Eric Seidel (no email)]

(In reply to comment #4)
> (From update of attachment 5393 [details] [edit])
> What removes the "-svg" (or is it "--svg"?) if that is passed as an argument?
> 

Oh, that's automatically done by Getopt::Long

At least when it's loaded wiht the "pass through" option, like it is in this script:

use Getopt::Long qw(:config pass_through);

[Eric Seidel (no email)]

Comment on attachment 5393 [details]
fix.

I've addressed darin's question in the bug.

[Darin Adler]

Comment on attachment 5393 [details]
fix.

OK, r=me.