Bug 5839 - Close the 19,000+ leaks introduced during the DOM merger
Summary: Close the 19,000+ leaks introduced during the DOM merger
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-26 15:10 PST by Eric Seidel (no email)
Modified: 2005-11-27 14:53 PST (History)
0 users

See Also:


Attachments
Closes leaks from the DOM merger, adds back resource dumping, etc. (62.01 KB, patch)
2005-11-26 15:35 PST, Eric Seidel (no email)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-11-26 15:10:54 PST
Close the 19,000+ leaks introduced during the DOM merger

The attach patch closes all known leaks in WebKit+SVG.
Comment 1 Eric Seidel (no email) 2005-11-26 15:11:05 PST
The patch also includes a (necessary) optimization to KCanvasContainer::paint() and (RenderPath::paint()) 
to not push a new KRenderingDeviceContext onto the context stack if one has already been pushed.  Not 
adding this optimization was causing CGContextBeginTransparency layer to have kittens... I was never 
able to fully understand why, except that the transparency layer methods, as part of their silent context 
swapping, seem to assume a certain CGContextRef, CGContextRelease pattern which we don't seem to 
follow, even though my previous code seemed perfectly legal.
Comment 2 Eric Seidel (no email) 2005-11-26 15:35:50 PST
Created attachment 4811 [details]
Closes leaks from the DOM merger, adds back resource dumping, etc.
Comment 3 Maciej Stachowiak 2005-11-27 02:06:11 PST
Comment on attachment 4811 [details]
Closes leaks from the DOM merger, adds back resource dumping, etc.

__sharedRenderingDevice
Please remove the underscores from this, identifiers w/ two leading underscores
are reserved to the implementation.

Other than that r=me