Bug 5826 - Blocks with direction:rtl and overflow:auto or scroll have incorrect scrollbars
Summary: Blocks with direction:rtl and overflow:auto or scroll have incorrect scrollbars
Status: VERIFIED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-25 11:25 PST by mitz
Modified: 2005-12-11 08:24 PST (History)
0 users

See Also:


Attachments
testcase (1.99 KB, text/html)
2005-11-25 11:26 PST, mitz
no flags Details
Proposed patch (7.98 KB, patch)
2005-11-25 11:28 PST, mitz
mjs: review+
Details | Formatted Diff | Diff
Improved testcase, in patch form (10.05 KB, patch)
2005-11-30 08:46 PST, mitz
no flags Details | Formatted Diff | Diff
expected result for the pixel test (51.49 KB, image/png)
2005-11-30 08:48 PST, mitz
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2005-11-25 11:25:34 PST
For blocks with direction:rtl and overflow:auto or scroll, the scrollable area should consist of the right 
corner of the block and any overflow to the left and down, and none of the overflow to the right. The 
initially visible area should be the right side of the scrollable area (i.e. the scrollbar should be all the way 
to the right). (This mirrors the behavior for ltr blocks).

In the testcase, the scrollable areas for the top 5 cases should mirror those of the bottom 5 cases.
Comment 1 mitz 2005-11-25 11:26:36 PST
Created attachment 4798 [details]
testcase
Comment 2 mitz 2005-11-25 11:28:29 PST
Created attachment 4799 [details]
Proposed patch
Comment 3 Darin Adler 2005-11-25 13:47:29 PST
Comment on attachment 4799 [details]
Proposed patch

Looks good, but I'd like Dave Hyatt to review this one.
Comment 4 Dave Hyatt 2005-11-26 00:04:45 PST
Did you leave the scrollbar on the far right, or did you move it to the far left like WinIE does?
Comment 5 mitz 2005-11-26 00:25:10 PST
(In reply to comment #4)
> Did you leave the scrollbar on the far right, or did you move it to the far left like WinIE does?

I left the vertical scrollbar on the far right. This is the Mac OS X way :-)
Comment 6 Maciej Stachowiak 2005-11-28 14:11:55 PST
Comment on attachment 4799 [details]
Proposed patch

hyatt says it's ok
Comment 7 Eric Seidel (no email) 2005-11-29 18:24:15 PST
It's not clear to me from the test case what is right or wrong, but I have not applied the patch yet.
Comment 8 mitz 2005-11-30 08:46:23 PST
Created attachment 4874 [details]
Improved testcase, in patch form
Comment 9 mitz 2005-11-30 08:48:05 PST
Created attachment 4875 [details]
expected result for the pixel test