Bug 5747 – KCPathData needs to be redesigned

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Eric Seidel (no email)]

KCPathData needs to be redesigned

Currently in KCanvas, there is this strange KCPathData class, which I think exists only for AGG support (in 
linux), since linux renderers may not have their own path structures.  In CG, we'd really like to use 
CGPaths, even if they are wrapped in some other structure.  We'd like to re-work KCanvas to have 
KCPathData abstracted so that it can be a real CGpath on our platform, and whatever else on KDE.  This 
would make converting between the two, transparent (and get rid of the need for 2 types of path data in 
KCanvas)

[Eric Seidel (no email)]

Created attachment 4963 [details]
replace KCPathDataList & KCanvasUserData with KCanvasPath (abstract)

This patch removes the previous *two* path representations in KCanvas/KSVG2 and
replaces them with a single improved path representation: KCanvasPath. 
KCanvasPath is an abstract class, (KCanvasPathQuartz concrete implementation)
which are vended from the appropriate KRenderingDevice
(QPainter::renderingDevice() in our implementation).  This dramatically
simplifies path handling code and is a major improvement in KCanvas design.

[Eric Seidel (no email)]

Comment on attachment 4963 [details]
replace KCPathDataList & KCanvasUserData with KCanvasPath (abstract)

See comments in the bug.  This is a pretty straightforward patch.  I welcome
anyone to give it a go.  There are a couple things you will see here:

1.  Removing KCanvasUserData and KCPathData/KCPathDataList, instead replacing
them with KCanvasPath*.

2.  Several places where I renamed "list" to "path" and change . access to ->.

3.  Flat-out removal of several unneeded methods from KRenderingDeviceQuartz,
KCanvasCreator, KCanvasMatrix.

4.  Minor adjustments to the rest of the code to use the new KCanvasPath type.

[Eric Seidel (no email)]

Comment on attachment 4963 [details]
replace KCPathDataList & KCanvasUserData with KCanvasPath (abstract)

Actually, I have a slightly better patch I'll post.

[Eric Seidel (no email)]

Created attachment 4976 [details]
Slightly improved KCanvasPath fix (now with bonus ChangeLog!)

[Eric Seidel (no email)]

Comment on attachment 4976 [details]
Slightly improved KCanvasPath fix (now with bonus ChangeLog!)

See previous comments in the bug for more information.

[Eric Seidel (no email)]

KDE will want to pick this up.