Bug 5725 – setAttributeNS with null namespace sets namespace to string containing 'null'

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Anders Carlsson]

This is actually three bugs which are related:

Due to a typo, the code in isEqualNode doesn't check if the attributes differ.

When fixing this, one of the DOM3 tests started failing. This is because the tests load documents by 
loading them in a frame/iframe (I'm not sure) and then cloning the document manually. In this code, 
there's a call to setAttributeNS which sets the namespaceURI to 'null', so it won't be the same as the 
original.

When fixing the setAttributeNS bug, run-webkit-tests started crashing. This is because a call to 
setAttributeNS to set the src on a <script> element would now result in the url being loaded (That 
wasn't the case before when the namespaceURI always was null) and we don't support loading external 
scripts from viewless documents (documents created by document.implementation.createDocument)
While we do want to load external scripts later (for xbl according to hyatt) I just made it return 
immediatly when there's no part available.

[Anders Carlsson]

Created attachment 4678 [details]
Patch

I don't really like the name valueToStringWithNullCheck but I couldn't come up
with any better...

[Anders Carlsson]

*** Bug 5724 has been marked as a duplicate of this bug. ***

[Eric Seidel (no email)]

Comment on attachment 4678 [details]
Patch

We talked about this on IRC.  Anders is going to file a bug about scripts not
being evaluated on viewless documents.	Otherwise this looks fine to me.

[Lucas Forschler]

Mass moving XML DOM bugs to the "DOM" Component.