Bug 5711 - Remove APPLE_CHANGES blocks and unused code from khtml
Summary: Remove APPLE_CHANGES blocks and unused code from khtml
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-11 11:35 PST by Eric Seidel (no email)
Modified: 2005-11-20 17:17 PST (History)
0 users

See Also:


Attachments
patch removing APPLE_CHANGES (413.06 KB, patch)
2005-11-11 11:36 PST, Eric Seidel (no email)
mjs: review+
Details | Formatted Diff | Diff
cleanup script (351 bytes, text/x-perl-script)
2005-11-11 11:36 PST, Eric Seidel (no email)
no flags Details
A hacked version of the partial preprocessor (17.53 KB, text/x-perl-script)
2005-11-11 11:37 PST, Eric Seidel (no email)
no flags Details
A better hacked version of partpp.pl (17.54 KB, text/x-perl-script)
2005-11-20 17:17 PST, Eric Seidel (no email)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-11-11 11:35:09 PST
We've forked from khtml... let's admit that to ourselves.

I think it's time to clean up the code and remove all the APPLE_CHANGES defines and blocks from khtml.

I've attached a patch which does just that, as well as the scripts I used to make this happen.
Comment 1 Eric Seidel (no email) 2005-11-11 11:36:10 PST
Created attachment 4667 [details]
patch removing APPLE_CHANGES
Comment 2 Eric Seidel (no email) 2005-11-11 11:36:48 PST
Created attachment 4668 [details]
cleanup script
Comment 3 Eric Seidel (no email) 2005-11-11 11:37:14 PST
Created attachment 4669 [details]
A hacked version of the partial preprocessor
Comment 4 Eric Seidel (no email) 2005-11-11 11:37:58 PST
Comment on attachment 4667 [details]
patch removing APPLE_CHANGES

This patch removes all mention of APPLE_CHANGES from khtml, as well as removes
unused #if 0 blocks.
Comment 5 Maciej Stachowiak 2005-11-11 18:42:54 PST
r=me assuming the results build and pass tests
Comment 6 Eric Seidel (no email) 2005-11-20 17:17:33 PST
Created attachment 4751 [details]
A better hacked version of partpp.pl