Bug 5686 - make Shared::deref faster by eliminating multiple branches
Summary: make Shared::deref faster by eliminating multiple branches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Enhancement
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-09 08:42 PST by Darin Adler
Modified: 2019-03-13 22:47 PDT (History)
0 users

See Also:


Attachments
get rid of the double if statement in deref without changing semantics (4.85 KB, patch)
2005-11-09 08:43 PST, Darin Adler
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2005-11-09 08:42:45 PST
 
Comment 1 Darin Adler 2005-11-09 08:43:21 PST
Created attachment 4649 [details]
get rid of the double if statement in deref without changing semantics
Comment 2 Eric Seidel (no email) 2005-11-09 12:15:36 PST
Comment on attachment 4649 [details]
get rid of the double if statement in deref without changing semantics

The ref changes look fine.  Changing RenderWidget not to be a subclass of
Shared seems a bit unnecessary (all the Shared functions are inline to begin
with), but it's not a big deal either.