Bug 5643 - setDragImage fails when passed Image object
Summary: setDragImage fails when passed Image object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-06 06:29 PST by Anders Carlsson
Modified: 2005-11-10 06:04 PST (History)
0 users

See Also:


Attachments
Return an NSImage instead (1.87 KB, patch)
2005-11-06 06:32 PST, Anders Carlsson
darin: review+
Details | Formatted Diff | Diff
just for grins, here's the patch I meant (43.81 KB, patch)
2005-11-06 12:07 PST, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2005-11-06 06:29:34 PST
On debug builds, setDragImage fails with an assertion when the object passed in is an image. This is 
because KWQClipboard::dragNSImage incorrectly returns a WebImageRenderer object instead of an 
NSImage.
Comment 1 Anders Carlsson 2005-11-06 06:32:32 PST
Created attachment 4612 [details]
Return an NSImage instead
Comment 2 Darin Adler 2005-11-06 11:55:45 PST
Comment on attachment 4612 [details]
Return an NSImage instead

I've got a patch that includes this change and many others like this, already
reviewed and ready to check in. But I haven't had a chance to land it yet.
Comment 3 Darin Adler 2005-11-06 12:07:49 PST
Created attachment 4615 [details]
just for grins, here's the patch I meant

Actually, it's not reviewed. I'll attach it here anyway.