In order to make bidi regressions more detectable by the layout tests, render tree dumps should indicate if m_reversed or m_dirOverride is set for every inlineTextBox. Printing the flag only when it's set means that most expected results won't have to be updated.
Sounds like a good idea.
Created attachment 4463 [details] Dump bidi flags
Comment on attachment 4463 [details] Dump bidi flags After (some revision of) this is accepted, I'll diff the expected results.
Comment on attachment 4463 [details] Dump bidi flags Look fine. Lets do it!
Created attachment 4464 [details] expected results diffs Diffs for all tests that the patch affects except fast/text/international/bidi-explicit-embedding, whose expected results are out of date following the patch for bug 5414.
Created attachment 4465 [details] expected results diff added bidi-explicit-embedding