Bug 5486 - DumpRenderTree should print the RTL and directional override flags for text runs
Summary: DumpRenderTree should print the RTL and directional override flags for text runs
Status: VERIFIED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P3 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-24 14:40 PDT by mitz
Modified: 2005-12-18 08:17 PST (History)
0 users

See Also:


Attachments
Dump bidi flags (972 bytes, patch)
2005-10-24 15:01 PDT, mitz
darin: review+
Details | Formatted Diff | Diff
expected results diffs (145.48 KB, patch)
2005-10-24 16:20 PDT, mitz
no flags Details | Formatted Diff | Diff
expected results diff (152.42 KB, patch)
2005-10-24 16:53 PDT, mitz
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2005-10-24 14:40:40 PDT
In order to make bidi regressions more detectable by the layout tests, render tree dumps should indicate if 
m_reversed or m_dirOverride is set for every inlineTextBox. Printing the flag only when it's set means that 
most expected results won't have to be updated.
Comment 1 Darin Adler 2005-10-24 14:47:40 PDT
Sounds like a good idea.
Comment 2 mitz 2005-10-24 15:01:55 PDT
Created attachment 4463 [details]
Dump bidi flags
Comment 3 mitz 2005-10-24 15:07:47 PDT
Comment on attachment 4463 [details]
Dump bidi flags

After (some revision of) this is accepted, I'll diff the expected results.
Comment 4 Darin Adler 2005-10-24 15:25:01 PDT
Comment on attachment 4463 [details]
Dump bidi flags

Look fine. Lets do it!
Comment 5 mitz 2005-10-24 16:20:29 PDT
Created attachment 4464 [details]
expected results diffs

Diffs for all tests that the patch affects except
fast/text/international/bidi-explicit-embedding, whose expected results are out
of date following the patch for bug 5414.
Comment 6 mitz 2005-10-24 16:53:36 PDT
Created attachment 4465 [details]
expected results diff

added bidi-explicit-embedding