Bug 54663 - Stop using RenderThemeSafari when running regression tests
Summary: Stop using RenderThemeSafari when running regression tests
Status: RESOLVED DUPLICATE of bug 25592
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-02-17 08:02 PST by Adam Roben (:aroben)
Modified: 2011-04-07 08:30 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-02-17 08:02:25 PST 
DumpRenderTree and WebKitTestRunner use RenderThemeSafari instead of RenderThemeWin. This is good for sharing results with Mac, but bad for testing the code that actually runs on users machines. It's also a maintenance burden; as new form controls are added, support for them needs to be added to RenderThemeSafari, even though users will never see that version of the form control! (E.g., bug 48690, bug 54662)

We should probably switch from using RenderThemeSafari to using RenderThemeWin when running regression tests. Unfortunately this will mean having more Windows-specific results. But it's just silly not to be testing code that users actually use.
Comment 1 Adam Roben (:aroben) 2011-02-17 08:02:55 PST 
<rdar://problem/9017127>
Comment 2 Adam Roben (:aroben) 2011-04-07 08:30:04 PDT 

*** This bug has been marked as a duplicate of bug 25592 ***