Bug 5465 – REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)

• Status: VERIFIED
• Resolution: FIXED
• Component: Forms

[Alexey Proskuryakov]

Radio buttons for content-type are supposed to be disabled for patches in Bugzilla, but they aren't.

Steps to reproduce:
1. Click "Create a New Attachment" link for this (any) bug report.
2. Click "patch" checkbox.

Expected results: the radio buttons below should get disabled
Results: they aren't.

Works fine in 2.0.1. This has regressed quite a while ago (a couple of months, perhaps).

[Adele Peterson]

I think the checkbox's onchange event isn't getting fired.

[Adele Peterson]

Created attachment 4693 [details]
Patch to call onChange() after a radio button or a checkbox is checked

[Adele Peterson]

Comment on attachment 4693 [details]
Patch to call onChange() after a radio button or a checkbox is checked

Dave- I saw that in onchange, you had this comment:  "// ### make this work
with new form events architecture" ... So I wasn't sure if this is too limited
of a fix.  But it definitely cures the symptom.

[Adele Peterson]

Created attachment 4694 [details]
layout test for checkbox onchange.

attaching layout test

[Dave Hyatt]

Not sure what the layout test is trying to illustrate.  onchange doesn't fire in Safari 2.0 or Firefox for that 
test case.

[Dave Hyatt]

Comment on attachment 4693 [details]
Patch to call onChange() after a radio button or a checkbox is checked

I don't think the timing of onchange is right here.

[Adele Peterson]

weird, I see onchange fire (and the test case pass) for Safari 2.0.2 and FF, but not on TOT.

[Darin Adler]

Comment on attachment 4693 [details]
Patch to call onChange() after a radio button or a checkbox is checked

Dave, the test case  *does* fire an onchange event in Firefox. You should
reconsider. I think this patch is correct.

[Maciej Stachowiak]

This patch needs copyright notice, test case included in patch, and ChangeLog entry to comply with 
WebKit patch submission guidelines. Otherwise the change looks correct to me (I can confirm that the test 
case passes in Firefox and Safari 2.0.2 but fails in TOT Safari).

[Maciej Stachowiak]

Comment on attachment 4693 [details]
Patch to call onChange() after a radio button or a checkbox is checked

I hate to r- a correct-looking one-liner over technicalities but them's the
rules. In case of emergency we'd probably merge this anyway.

[Adele Peterson]

Created attachment 5073 [details]
updated patch

here's an updated patch w/ changelog

[Adele Peterson]

Created attachment 5074 [details]
new testcase

also tests radio buttons now too