Bug 5351 – SVG: Safari ignores <title> elements

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Nicholas Shanks]

An SVG document can contain an image title encoded in a <title> element just as it is in HTML. One would 
expect these to alter the title bar of a window if the SVG is the root document, however this does not 
currently happen. For SVG documents loaded via HTML <image/> or <object/> elements, if they do not 
already have a title, this should be substituted.

[Eric Seidel (no email)]

http://www.w3.org/TR/SVG/struct.html#TitleElement
is the section covering this.

This basically just involves extending the KDOMDocumentWrapper object to set the 
DOM::DocumentImpl::title() property, after parsing.

Passing this down into an <img> or <object> tag might be harder... but possible.

[Nicholas Shanks]

Yeah, <img/>, that's what I meant. I'm not going mad am I?

[Julien Palmas]

Created attachment 4509 [details]
Proposed patch

Like eric said, just set the DocumentImpl title with the svgDoc->title in
KDOMTokenizer::finish()

[Eric Seidel (no email)]

Comment on attachment 4509 [details]
Proposed patch

Thanks for the great patch.  Unfortunatley (or fortunately?) this is no longer
needed after the DOM merger, which I am preparing to land.

[Rob Buis]

Created attachment 7081 [details]
Set the title for svg too

The patch works for standalone svg documents. When embedded in xhtml
any title tag in the xhtml "wins". Note that the patch may lack some optimizations, also svg handling seems a bit different since when the svg title element is inserted by the parser the title text is not processed yet, unlike with the html parser.

[Eric Seidel (no email)]

Comment on attachment 7081 [details]
Set the title for svg too

Rob and I discussed several fixes on IRC.

textContent() should be used in place of a m_title.

There were some tabs in these files.

Also we use if ( instead of if(

[Rob Buis]

Created attachment 7109 [details]
Set the window caption for svg <title>

Now uses String instead of DOMString, no tabs, uses if ( and textContent().
Cheers,

Rob.

[Darin Adler]

Comment on attachment 7109 [details]
Set the window caption for svg <title>

Is there a way we can share the code instead of having to copy the HTML title element code?

[Darin Adler]

Comment on attachment 7109 [details]
Set the window caption for svg <title>

r=me