RESOLVED FIXED 5331
Percentage values for width, height, rx and ry not rendered correctly 
https://bugs.webkit.org/show_bug.cgi?id=5331
Summary Percentage values for width, height, rx and ry not rendered correctly
Julien Palmas
Reported 2005-10-10 18:44:48 PDT
Both of these attributes are defined as #IMPLIED in the DTD. Webkit+svg fails to define them correctly if missing. An example is here : http://www.croczilla.com/svg/samples/tiger/tiger.svg Just add width="800" or anything else in the <svg> element and the problem disappears. You can also check with drawTest. The rendering is done, but not on the white background.
Attachments
reduced test case (122 bytes, image/svg+xml)
2005-10-12 17:54 PDT, Julien Palmas 		no flags
Details
Temporary patch (1.80 KB, patch)
2005-10-23 04:31 PDT, Julien Palmas 		no flags
DetailsFormatted DiffDiff
Testcase for percentage sized rect (168 bytes, image/svg+xml)
2006-01-22 03:28 PST, Joost de Valk (AlthA) 		no flags
Details
Testcase for percentage rounded rectangle (184 bytes, image/svg+xml)
2006-01-22 03:34 PST, Joost de Valk (AlthA) 		no flags
Details
patch fixing issue (4.76 KB, patch)
2006-01-22 15:57 PST, Alexander Kellett 		eric: review-
DetailsFormatted DiffDiff
Patch with corrected comments, and test case demonstrating incorrect fix. (6.88 KB, patch)
2006-01-22 16:48 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Simple test case (168 bytes, image/svg+xml)
2006-01-22 16:49 PST, Eric Seidel (no email) 		no flags
Details
latest patch with code removal and corrected comments (4.57 KB, patch)
2006-01-25 13:36 PST, Alexander Kellett 		no flags
DetailsFormatted DiffDiff
svn-create-patch version of previous patch for WebCore (4.69 KB, patch)
2006-01-25 13:47 PST, Alexander Kellett 		eric: review+
DetailsFormatted DiffDiff
layouttests patch (851 bytes, patch)
2006-01-25 13:48 PST, Alexander Kellett 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Julien Palmas
Comment 1 2005-10-12 17:54:02 PDT
Created attachment 4335 [details] reduced test case
Julien Palmas
Comment 2 2005-10-23 04:29:36 PDT
When width or height are not specified in the <svg> element, they are implied as 100% (according to the spec) but the render fails, 100% is not mapped to the actual window size Same thing for an element like <rect> with width or height set with percentage. The element will not render. This bug is specific to OSX.
Julien Palmas
Comment 3 2005-10-23 04:31:44 PDT
Created attachment 4446 [details] Temporary patch A simple patch to handle the case where only width or height is not specified in the <svg> element.
Eric Seidel (no email)
Comment 4 2005-12-13 00:27:08 PST
This is still a bug in TOT.
Eric Seidel (no email)
Comment 5 2006-01-15 03:00:29 PST
Looks OK, but might be because we're not clipping the <svg>: http://bugzilla.opendarwin.org/show_bug.cgi?id=6093
Joost de Valk (AlthA)
Comment 6 2006-01-22 03:26:41 PST
*** Bug 6599 has been marked as a duplicate of this bug. ***
Joost de Valk (AlthA)
Comment 7 2006-01-22 03:28:20 PST
Created attachment 5830 [details] Testcase for percentage sized rect
Joost de Valk (AlthA)
Comment 8 2006-01-22 03:29:09 PST
Comment on attachment 4446 [details] Temporary patch This code is no longer usable... Submitter: please set a review flag next time.
Joost de Valk (AlthA)
Comment 9 2006-01-22 03:30:35 PST
Increasing to P2, SVG without support for % for scaling .... well you get it :)
Joost de Valk (AlthA)
Comment 10 2006-01-22 03:33:06 PST
Changing subject, rounded corners don't work either, testcase forthcoming.
Joost de Valk (AlthA)
Comment 11 2006-01-22 03:34:15 PST
Created attachment 5833 [details] Testcase for percentage rounded rectangle
Alexander Kellett
Comment 12 2006-01-22 15:57:32 PST
Created attachment 5854 [details] patch fixing issue
Eric Seidel (no email)
Comment 13 2006-01-22 16:19:10 PST
Comment on attachment 5854 [details] patch fixing issue I'm not sure this fix is really complete (What about % used for text or images, or <svg>?) I also think the comment could be cleaner. I can fix the comments on landing since they're trivial issues, and we'll use other bugs to track the missing support.
Eric Seidel (no email)
Comment 14 2006-01-22 16:47:47 PST
Comment on attachment 5854 [details] patch fixing issue Actually looking at this further, this does not fix the issue. I'm posting a patch which contains slightly modified comments, as well as a test case which demonstrates how this patch is incorrrect.
Eric Seidel (no email)
Comment 15 2006-01-22 16:48:32 PST
Created attachment 5857 [details] Patch with corrected comments, and test case demonstrating incorrect fix.
Eric Seidel (no email)
Comment 16 2006-01-22 16:49:40 PST
Created attachment 5858 [details] Simple test case
Alexander Kellett
Comment 17 2006-01-25 13:36:40 PST
Created attachment 5959 [details] latest patch with code removal and corrected comments
Alexander Kellett
Comment 18 2006-01-25 13:47:32 PST
Created attachment 5960 [details] svn-create-patch version of previous patch for WebCore
Alexander Kellett
Comment 19 2006-01-25 13:48:14 PST
Created attachment 5961 [details] layouttests patch
Eric Seidel (no email)
Comment 20 2006-01-25 14:29:28 PST
Comment on attachment 5960 [details] svn-create-patch version of previous patch for WebCore Looks great! r=me.
Eric Seidel (no email)
Comment 21 2006-01-25 14:31:29 PST
Comment on attachment 5961 [details] layouttests patch I'll tweak this a bit when I land, but looks good. Thanks again. r=me.
Eric Seidel (no email)
Comment 22 2006-01-26 01:32:17 PST
Thanks again Alexander.
Note You need to log in before you can comment on or make changes to this bug.