Bug 5239 - Viewing a particular SVG image causes Safari+SVG to stop responding.
Summary: Viewing a particular SVG image causes Safari+SVG to stop responding.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Eric Seidel (no email)
URL: http://upload.wikimedia.org/wikipedia...
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-02 19:58 PDT by Tobin Richard
Modified: 2005-10-03 01:52 PDT (History)
0 users

See Also:


Attachments
Stop da loop (514 bytes, patch)
2005-10-03 00:28 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
stop da loop II (583 bytes, patch)
2005-10-03 01:08 PDT, Rob Buis
eric: review+
Details | Formatted Diff | Diff
More informative error reporting (704 bytes, patch)
2005-10-03 01:24 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobin Richard 2005-10-02 19:58:20 PDT
Attempting to open http://upload.wikimedia.org/wikipedia/en/0/01/Eye.svg (linked
to from http://en.wikipedia.org/wiki/Image:Eye.svg) causes Safari+SVG (latest
build from 2005-09-03) to stop responding.
Comment 1 Eric Seidel (no email) 2005-10-02 23:34:46 PDT
Wow, thanks for the bug!

It looks like
SVGPathParser::parseSVG( const QString &s, bool process )

is just not robust enough.  This particular SVG has a non-ascii character right in the middle of a pata data 
attribute string, and it's causing parseSVG to just loop forever.  I'll talk this one out with the KSVG2 guys 
and see if we can't come up with a fix.
Comment 2 Rob Buis 2005-10-03 00:26:58 PDT
(In reply to comment #0) 
> Attempting to open http://upload.wikimedia.org/wikipedia/en/0/01/Eye.svg 
(linked 
> to from http://en.wikipedia.org/wiki/Image:Eye.svg) causes Safari+SVG (latest 
> build from 2005-09-03) to stop responding. 
 
Good catch! I'll attach a patch that seems to work. I am checking whether 
just skipping the invalid char is according to svg... 
Cheers, 
 
Rob. 
Comment 3 Rob Buis 2005-10-03 00:28:25 PDT
Created attachment 4169 [details]
Stop da loop
Comment 4 Rob Buis 2005-10-03 01:08:56 PDT
Created attachment 4174 [details]
stop da loop II
Comment 5 Eric Seidel (no email) 2005-10-03 01:10:53 PDT
Comment on attachment 4174 [details]
stop da loop II

Looks fine. r=me
Comment 6 Rob Buis 2005-10-03 01:24:46 PDT
Created attachment 4175 [details]
More informative error reporting
Comment 7 Eric Seidel (no email) 2005-10-03 01:52:45 PDT
Thanks for the great bug!