Bug 5231 - attributes don't return correct values for namespaceURI and localName
Summary: attributes don't return correct values for namespaceURI and localName
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-02 04:15 PDT by Anders Carlsson
Modified: 2019-02-06 09:04 PST (History)
1 user (show)

See Also:


Attachments
Implement localName and namespaceURI for documents (2.11 KB, patch)
2005-10-02 04:20 PDT, Anders Carlsson
eric: review+
Details | Formatted Diff | Diff
Test case (2.11 KB, patch)
2005-10-02 04:21 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Correct patch (2.78 KB, patch)
2005-10-02 04:22 PDT, Anders Carlsson
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2005-10-02 04:15:24 PDT
namespaceURI and localName aren't implemented for AttrImpl nodes.
Comment 1 Anders Carlsson 2005-10-02 04:20:49 PDT
Created attachment 4143 [details]
Implement localName and namespaceURI for documents
Comment 2 Anders Carlsson 2005-10-02 04:21:13 PDT
Created attachment 4144 [details]
Test case
Comment 3 Anders Carlsson 2005-10-02 04:22:03 PDT
Created attachment 4145 [details]
Correct patch
Comment 4 Eric Seidel (no email) 2005-10-02 10:03:11 PDT
Comment on attachment 4145 [details]
Correct patch

looks great, r=me.  ideally it would have an end-of-file newline, but I'll fix
as I'm landing.
Comment 5 Eric Seidel (no email) 2005-10-02 10:03:42 PDT
Comment on attachment 4143 [details]
Implement localName and namespaceURI for documents

Looks good.
Comment 6 Darin Adler 2005-10-02 21:06:29 PDT
Just call me Mr. Premature Optimization -- I'd have made these inline functions.
Comment 7 Darin Adler 2005-10-02 22:48:45 PDT
Anders landed this but forgot to mark it resolved.
Comment 8 Lucas Forschler 2019-02-06 09:04:10 PST
Mass moving XML DOM bugs to the "DOM" Component.