WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
5189
pcre_exec.c fails to compile using MSVC
https://bugs.webkit.org/show_bug.cgi?id=5189
Summary
pcre_exec.c fails to compile using MSVC
Justin Haygood
Reported
2005-09-29 12:41:50 PDT
PCRE 6.1's pcre_exec.c fails to compile using MSVC. Work Arounds to compile correctly: Compile using C++ instead of C Apply following patch (does the exact same thing as original, but seperates declaration of initial assignment)
Attachments
Separates int utf16Length declaration and assignment into 2 lines.
(625 bytes, patch)
2005-09-29 12:43 PDT
,
Justin Haygood
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Justin Haygood
Comment 1
2005-09-29 12:43:31 PDT
Created
attachment 4095
[details]
Separates int utf16Length declaration and assignment into 2 lines.
Justin Haygood
Comment 2
2005-09-29 12:44:22 PDT
Comment on
attachment 4095
[details]
Separates int utf16Length declaration and assignment into 2 lines. Very simple fix, without which MSVC will claim not to see the initial declaration, and die trying.
Darin Adler
Comment 3
2005-09-30 07:37:46 PDT
Comment on
attachment 4095
[details]
Separates int utf16Length declaration and assignment into 2 lines. Code change looks OK (but strange, amazing that MSVC has this bug), but patch has a tab in it. Lets not add a tab to the file.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug