Bug 5189 - pcre_exec.c fails to compile using MSVC
Summary: pcre_exec.c fails to compile using MSVC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-29 12:41 PDT by Justin Haygood
Modified: 2005-10-08 21:21 PDT (History)
0 users

See Also:


Attachments
Separates int utf16Length declaration and assignment into 2 lines. (625 bytes, patch)
2005-09-29 12:43 PDT, Justin Haygood
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Haygood 2005-09-29 12:41:50 PDT
PCRE 6.1's pcre_exec.c fails to compile using MSVC.

Work Arounds to compile correctly:

Compile using C++ instead of C
Apply following patch (does the exact same thing as original, but seperates
declaration of initial assignment)
Comment 1 Justin Haygood 2005-09-29 12:43:31 PDT
Created attachment 4095 [details]
Separates int utf16Length declaration and assignment into 2 lines.
Comment 2 Justin Haygood 2005-09-29 12:44:22 PDT
Comment on attachment 4095 [details]
Separates int utf16Length declaration and assignment into 2 lines.

Very simple fix, without which MSVC will claim not to see the initial
declaration, and die trying.
Comment 3 Darin Adler 2005-09-30 07:37:46 PDT
Comment on attachment 4095 [details]
Separates int utf16Length declaration and assignment into 2 lines.

Code change looks OK (but strange, amazing that MSVC has this bug), but patch
has a tab in it. Lets not add a tab to the file.