Bug 5161 - move HashMap/HashSet code down to JavaScriptCore
Summary: move HashMap/HashSet code down to JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-27 23:47 PDT by Maciej Stachowiak
Modified: 2005-09-28 15:17 PDT (History)
0 users

See Also:


Attachments
do it (also renamed HashMap::insert to HashMap::set for clarity) (133.57 KB, patch)
2005-09-28 01:44 PDT, Maciej Stachowiak
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2005-09-27 23:47:06 PDT
HashSet and HashMap should be moved down to JavaScriptCore so we can have a single hashtable 
implementation to meet all our hashing needs.
Comment 1 Maciej Stachowiak 2005-09-28 01:44:39 PDT
Created attachment 4076 [details]
do it (also renamed HashMap::insert to HashMap::set for clarity)

I measured and found no JS iBench or cvs-base performance regressions with this
patch.
Comment 2 Maciej Stachowiak 2005-09-28 15:17:51 PDT
Comment on attachment 4076 [details]
do it (also renamed HashMap::insert to HashMap::set for clarity)

Eric said ok to this.