Bug 5145 - Replace dlmalloc with tcmalloc
Summary: Replace dlmalloc with tcmalloc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-26 23:51 PDT by Maciej Stachowiak
Modified: 2005-09-27 21:57 PDT (History)
0 users

See Also:


Attachments
Do it (also move a bit more stuff into kxmlcore) (717.02 KB, patch)
2005-09-27 00:19 PDT, Maciej Stachowiak
mjs: review-
Details | Formatted Diff | Diff
improved version (717.54 KB, patch)
2005-09-27 02:04 PDT, Maciej Stachowiak
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2005-09-26 23:51:53 PDT
Google's tcmalloc is fully threadsafe but just as fast as dlmalloc. This means we can avoid having two 
copies and won't need to follow weird threadsafety disciplines.
Comment 1 Maciej Stachowiak 2005-09-27 00:19:03 PDT
Created attachment 4057 [details]
Do it (also move a bit more stuff into kxmlcore)
Comment 2 Maciej Stachowiak 2005-09-27 02:04:22 PDT
Created attachment 4060 [details]
improved version

I forgot to fall back to normal malloc in debug builds. Also fixed a few things
that were ifdef'd wrong.
Comment 3 John Sullivan 2005-09-27 13:45:44 PDT
Comment on attachment 4060 [details]
improved version

I talked with mjs about this on IRC.