Bug 5112 - Finish deploying PropertySlot in the interpreter
Summary: Finish deploying PropertySlot in the interpreter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-23 18:31 PDT by Maciej Stachowiak
Modified: 2005-09-24 15:32 PDT (History)
0 users

See Also:


Attachments
The patch (129.62 KB, patch)
2005-09-23 18:34 PDT, Maciej Stachowiak
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2005-09-23 18:31:47 PDT
PropertySlot-based techniques should be used in place of evaluateReference in the remaining node types 
that still rely on it. Specifically this is PostfixNode, PrefixNode, DeleteNode, TypeOfNode and ForInNode.

This is also filed as rdar://problem/4260479
Comment 1 Maciej Stachowiak 2005-09-23 18:34:31 PDT
Created attachment 4023 [details]
The patch

Attached patch - as an added bonus it fixes two of the layout tests and gives a
3% JS iBench speedup.
Comment 2 Darin Adler 2005-09-23 20:20:07 PDT
Comment on attachment 4023 [details]
The patch

r=me