Bug 5037 - WebCore should handled MIME types to allow SVG support
Summary: WebCore should handled MIME types to allow SVG support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-18 03:47 PDT by Eric Seidel (no email)
Modified: 2005-09-20 02:54 PDT (History)
0 users

See Also:


Attachments
The webkit portion of the patch. (21.42 KB, patch)
2005-09-18 03:48 PDT, Eric Seidel (no email)
mjs: review-
Details | Formatted Diff | Diff
The WebCore portion of the patch. (1.53 KB, patch)
2005-09-18 03:49 PDT, Eric Seidel (no email)
mjs: review-
Details | Formatted Diff | Diff
Updated WebKit patch (23.80 KB, patch)
2005-09-20 01:03 PDT, Eric Seidel (no email)
mjs: review+
Details | Formatted Diff | Diff
Updated WebCore patch (1.54 KB, patch)
2005-09-20 01:04 PDT, Eric Seidel (no email)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-09-18 03:47:12 PDT
WebCore should handled MIME types to allow SVG support

Basically MIME type handling in WebKit should be cleaned up.  As part of that cleanup, the WebCore 
supported mime type list should be moved down into WebCore.

Patch attached.
Comment 1 Eric Seidel (no email) 2005-09-18 03:48:44 PDT
Created attachment 3931 [details]
The webkit portion of the patch.
Comment 2 Eric Seidel (no email) 2005-09-18 03:49:49 PDT
Created attachment 3932 [details]
The WebCore portion of the patch.
Comment 3 Maciej Stachowiak 2005-09-19 00:24:27 PDT
1) I suggest using NSArray instead of NSSet for the lists of supported MIME types; the associative 
properties of a set are not required, and so an array is likely to be more efficient.

2) I would support putting the list of supported MIME types in WebCore if it were shared with or used by 
WebCore in any way - as it is, it just seems to be adding more levels of indirection.
Comment 4 Eric Seidel (no email) 2005-09-20 01:03:31 PDT
Created attachment 3961 [details]
Updated WebKit patch
Comment 5 Eric Seidel (no email) 2005-09-20 01:04:31 PDT
Created attachment 3962 [details]
Updated WebCore patch
Comment 6 Maciej Stachowiak 2005-09-20 01:18:17 PDT
Comment on attachment 3962 [details]
Updated WebCore patch

r=me