VERIFIED FIXED 5028
9 layout tests fail following the change from long to int 
https://bugs.webkit.org/show_bug.cgi?id=5028
Summary 9 layout tests fail following the change from long to int
mitz
Reported 2005-09-17 13:46:25 PDT
After applying the patch for bug 4547, the following layout tests fail: dom/html/level2/html/HTMLTableElement35 dom/html/level2/html/HTMLTableElement38 dom/html/level2/html/HTMLTableRowElement16 dom/html/level2/html/HTMLTableRowElement19 dom/html/level2/html/HTMLTableSectionElement26 dom/html/level2/html/HTMLTableSectionElement29 fast/js/date-big-setmonth fast/js/date-parse-date fast/dom/quadraticCurveTo (draws a sine with ~1px amplitude along the axis) I'm putting them all together in one bug because it's likely that they have a common root cause (something broken in the way JS does math), and because I'm lazy.
Attachments
Fix by rolling out simple_number.h changes (2.84 KB, patch)
2005-09-18 15:39 PDT, Geoffrey Garen 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2005-09-18 15:39:52 PDT
Created attachment 3942 [details] Fix by rolling out simple_number.h changes Because we have JavaScriptCore test failures on TOT, I can't be sure that this patch is the right solution, but it fixes all the layout tests without introducing additional regressions to the JavaScriptCore tests.
Geoffrey Garen
Comment 2 2005-09-18 15:41:15 PDT
Comment on attachment 3942 [details] Fix by rolling out simple_number.h changes I think we should land this patch, land a fix for the other JSC regressions, and then go back and redo the int/long modifications to simple_number.h, once we have a working baseline of tests.
Maciej Stachowiak
Comment 3 2005-09-19 00:26:04 PDT
Comment on attachment 3942 [details] Fix by rolling out simple_number.h changes Given that this fixes the bug, r=me This change should be revisited however.
mitz
Comment 4 2005-09-19 15:24:26 PDT
I'm marking this verified even though date-big-setmonth is still failing for me. I seem to remember it failing even before the long->int move.
Geoffrey Garen
Comment 5 2005-09-19 15:40:01 PDT
date-big-setmonth was failing because it's not written to be TZ independent. I'll fix that.
mitz
Comment 6 2005-09-20 02:24:30 PDT
Opened bug 5061 about date-big-setmonth
Note You need to log in before you can comment on or make changes to this bug.