Bug 48713 – [GTK] Add support for <meter> element

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Yael]

Need to add support for <meter> element in RenderThemeGtk.cpp

[Martin Robinson]

I can tackle this, if no one else has plans to.

[Carlos Garcia Campos]

Created attachment 77410 [details]
Enable meter element in gtk port

We don't need any specific code in RenderThemeGtk. Gtk+ doesn't have a meter widget so there's no way to render them like gtk+. Using the default meter defined in html.css makes exactly the same output than chromium, for example, which I think is acceptable for gtk+ too.

[Martin Robinson]

Awesome! Thanks Carlos. Are these results for GTK+ 3.x or 2.x? We should also include pixel dumps.

[Daniel Bates]

Comment on attachment 77410 [details]
Enable meter element in gtk port

View in context: https://bugs.webkit.org/attachment.cgi?id=77410&action=review

> WebCore/GNUmakefile.am:3895
>  # HTML Meter Element - disable for now.

This comment should be updated. In particular, the phrase "disabled for now." should be removed.

[Carlos Garcia Campos]

(In reply to comment #3)
> Awesome! Thanks Carlos. Are these results for GTK+ 3.x or 2.x? We should also include pixel dumps.

Both, since we are not using gtk.

[Carlos Garcia Campos]

Created attachment 77490 [details]
Updated patch

Updated patch just updating the comment in Makefile as suggested by Daniel Bates

[Martin Robinson]

Comment on attachment 77490 [details]
Updated patch

Thanks! Please attach pixel results to this patch before landing it.

[Carlos Garcia Campos]

Committed r75507: <http://trac.webkit.org/changeset/75507>

[WebKit Review Bot]

http://trac.webkit.org/changeset/75507 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
fast/dom/HTMLMeterElement/meter-appearances-capacity.html
fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html
fast/dom/HTMLMeterElement/meter-boundary-values.html
fast/dom/HTMLMeterElement/meter-element-crash.html
fast/dom/HTMLMeterElement/meter-element-form.html
fast/dom/HTMLMeterElement/meter-element-with-child-crash.html
fast/dom/HTMLMeterElement/meter-element.html
fast/dom/HTMLMeterElement/meter-optimums.html
fast/dom/HTMLMeterElement/meter-percent-size.html
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-styles.html
fast/dom/HTMLMeterElement/set-meter-properties.html
fast/forms/form-attribute.html