Bug 4864 - Remove unnecessary KRenderingPaintServer creation
Summary: Remove unnecessary KRenderingPaintServer creation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-06 02:27 PDT by Tobias Lidskog
Modified: 2005-09-06 03:16 PDT (History)
0 users

See Also:

Attachments
patch to KCanvasRenderingStyle + test cases (151.48 KB, text/plain)
2005-09-06 02:30 PDT, Tobias Lidskog 		no flags Details
fix mime type, this is a .gz file (151.48 KB, application/octet-stream)
2005-09-06 02:32 PDT, Tobias Lidskog 		eric: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Lidskog 2005-09-06 02:27:32 PDT 
Currently KRenderingPaintServers are sometimes created even when there shouldn't be any fill/stroke. In 
the tree dump this can be seen as [stroke={}] and [fill={}]. Creating paint servers for strokes also has the 
side effect that bounding box calculation is effected. The problem lays in 
KCanvasRenderingStyle::updateFill/Stroke.
Comment 1 Tobias Lidskog 2005-09-06 02:30:38 PDT 
Created attachment 3780 [details]
patch to KCanvasRenderingStyle + test cases

Calling strokePainter()/fillPainter() will create a painter if none exists.
Don't do this if there shouldn't be any fill/stroke
Comment 2 Tobias Lidskog 2005-09-06 02:32:02 PDT 
Created attachment 3781 [details]
fix mime type, this is a .gz file
Comment 3 Eric Seidel (no email) 2005-09-06 03:08:28 PDT 
Comment on attachment 3781 [details]
fix mime type, this is a .gz file

Looks good to me.  r=me.