WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
VERIFIED FIXED
4849
htmltokenizer.cpp won't compile with TOKEN_DEBUG defined
https://bugs.webkit.org/show_bug.cgi?id=4849
Summary
htmltokenizer.cpp won't compile with TOKEN_DEBUG defined
Alexey Proskuryakov
Reported
2005-09-04 13:10:36 PDT
Several fixes to make it compile cleanly in debug mode (I'm using a locally modified KWQKDebug.h that actually prints something).
Attachments
proposed patch
(3.58 KB, patch)
2005-09-04 13:11 PDT
,
Alexey Proskuryakov
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2005-09-04 13:11:18 PDT
Created
attachment 3759
[details]
proposed patch
Oliver Hunt
Comment 2
2005-09-07 03:56:18 PDT
Mark the patch for review
Darin Adler
Comment 3
2005-09-07 08:19:39 PDT
Comment on
attachment 3759
[details]
proposed patch It's really ugly that this includes calls to operator->, and the string is not guaranteed to be contiguous, so it won't always work. But on the other hand, at least it compiles. Maybe later we'll just remove all this code. r=me
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug