Bug 4757 - leaks found by code inspection in apply-style command
Summary: leaks found by code inspection in apply-style command
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-30 10:47 PDT by Darin Adler
Modified: 2005-09-02 09:45 PDT (History)
0 users

See Also:

Attachments
patch to fix the leaks I spotted (4.71 KB, patch)
2005-08-30 10:48 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
patch revised to use SharedPtr as per Maciej's suggestion (14.58 KB, patch)
2005-09-01 09:35 PDT, Darin Adler 		mjs: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2005-08-30 10:47:13 PDT
Comment 1 Darin Adler 2005-08-30 10:48:18 PDT 
Created attachment 3675 [details]
patch to fix the leaks I spotted
Comment 2 Darin Adler 2005-08-31 00:31:31 PDT 
Comment on attachment 3675 [details]
patch to fix the leaks I spotted

I have no tests, but still probably should get this reviewed.
Comment 3 Maciej Stachowiak 2005-08-31 02:10:03 PDT 
Comment on attachment 3675 [details]
patch to fix the leaks I spotted

Perhaps it would be better to store the CSSValueImpls in a SharedPtr instead of
doing the ref()/deref() pair manually.
Comment 4 Darin Adler 2005-09-01 09:35:56 PDT 
Created attachment 3710 [details]
patch revised to use SharedPtr as per Maciej's suggestion
Comment 5 Maciej Stachowiak 2005-09-02 02:49:02 PDT 
Comment on attachment 3710 [details]
patch revised to use SharedPtr as per Maciej's suggestion

r=me