WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 4714
NodeIterator does not handle exceptions from the filter function (affects Acid3)
https://bugs.webkit.org/show_bug.cgi?id=4714
Summary
NodeIterator does not handle exceptions from the filter function (affects Acid3)
Darin Adler
Reported
2005-08-28 11:16:32 PDT
Looking at the NodeIterator code, it's clear that it doesn't do the right thing in the presence of exceptions. If the filter function raises an exception, the standard says that the exception should be propagated to the caller of nextNode or previousNode. But our NodeIterator implementation does not attempt to do that. Also, it calls the filter function from the "node removed" hook; it's not at all clear if it's appropriate to do so, nor what happens if the filter function raises an exception in that case.
Attachments
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2008-01-08 13:02:43 PST
***
Bug 16744
has been marked as a duplicate of this bug. ***
Darin Adler
Comment 2
2008-01-08 13:04:08 PST
***
Bug 16743
has been marked as a duplicate of this bug. ***
Darin Adler
Comment 3
2008-01-08 13:04:35 PST
Need to make sure when fixing this that we pass both test cases from Acid3, the one in
bug 16743
and the one in
bug 16744
.
Darin Adler
Comment 4
2008-01-08 22:52:21 PST
Bug 3492
now has a patch that addresses this.
Darin Adler
Comment 5
2008-02-08 02:36:07 PST
Committed revision 30089.
Lucas Forschler
Comment 6
2019-02-06 09:03:11 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug