Bug 4701 - Enable filter tests
Summary: Enable filter tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-27 17:59 PDT by Tobias Lidskog
Modified: 2005-08-28 04:18 PDT (History)
0 users

See Also:

Attachments
add null checks (19.53 KB, patch)
2005-08-27 18:01 PDT, Tobias Lidskog 		eric: review+
Details | Formatted Diff | Diff
sligthly better ifs (19.40 KB, patch)
2005-08-28 02:33 PDT, Tobias Lidskog 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Lidskog 2005-08-27 17:59:27 PDT 
filters-comptran-01-b and filters-turb-01-f are currently disabled because they crash when running run-
webkit-tests --svg
Comment 1 Tobias Lidskog 2005-08-27 18:01:04 PDT 
Created attachment 3612 [details]
add null checks

add null checks to allow tests to run. Also add the related test files. Note
that the svg-disabled files should be removed from cvs when this is landed, but
I could get the change to be included in the diff
Comment 2 Tobias Lidskog 2005-08-27 19:55:32 PDT 
(In reply to comment #1)
> ...but I could get the change to be included in the diff

should of course be ... I could *not* get the change to be included in the diff
Comment 3 Eric Seidel (no email) 2005-08-28 00:55:29 PDT 
Comment on attachment 3612 [details]
add null checks

These look fine.  Thanks!
Comment 4 Tobias Lidskog 2005-08-28 02:33:23 PDT 
Created attachment 3620 [details]
sligthly better ifs
Comment 5 Eric Seidel (no email) 2005-08-28 03:02:39 PDT 
Comment on attachment 3620 [details]
sligthly better ifs

Looks good.