RESOLVED FIXED 4674
LEAK: WheelEventImpl leaked when mousewheel used 
https://bugs.webkit.org/show_bug.cgi?id=4674
Summary LEAK: WheelEventImpl leaked when mousewheel used
Kurt Kohler
Reported 2005-08-26 16:52:22 PDT
A WheelEventImpl is leaked in NodeImpl::dispatchWheelEvent when a mouse wheel event is being handled. The problem appears to be missing ref/deref's around the call to dispatchEvent. I have a patch.
Attachments
Patch to add ref/deref (805 bytes, patch)
2005-08-26 16:54 PDT, Kurt Kohler 		ggaren: review-
DetailsFormatted DiffDiff
refptr patch (1.31 KB, patch)
2006-02-15 15:33 PST, Geoffrey Garen 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kurt Kohler
Comment 1 2005-08-26 16:54:28 PDT
Created attachment 3590 [details] Patch to add ref/deref This patch makes the code consistent with other event dispatchers, it *may* be correct.
Kurt Kohler
Comment 2 2005-08-26 17:10:42 PDT
I forgot to include the call stack that started the whole thing. Leak: 0x0bde14d0 size=112 0x019a4fa8 0x00000000 0x00000000 0x00000001 ..O............. 0x00000001 0x00000000 0x00000000 0x00000000 ................ 0x00000000 0x0000003a 0x00000000 0x000000ae .......:........ 0x00000000 0x41a17f6c 0xddc367a1 0x0a443030 ....A..l..g..D00 0x00000000 0x000003ed 0x00000259 0x00000176 ...........Y...v 0x00000230 0x00000371 0x00000230 0x00000371 ...0...q...0...q 0x00000001 0x000000c0 0x000014cc 0x00000007 ................ Call stack: [thread 26df]: | 0x0 | 0x57190 | 0x26e0 | NSApplicationMain | -[NSApplication run] | 0x1a684 | -[NSApplication sendEvent:] | 0x1d69c | -[NSWindow sendEvent:] | -[WebHTMLView scrollWheel:] | -[WebCoreBridge sendScrollWheelEvent:] | KWQKHTMLPart::wheelEvent(NSEvent*) | KHTMLView::viewportWheelEvent(QWheelEvent*) | DOM::NodeImpl::dispatchWheelEvent(QWheelEvent*) | DOM::EventImpl::operator new(unsigned long) | khtml::main_thread_malloc(unsigned long) | malloc
Oliver Hunt
Comment 3 2005-09-07 04:08:35 PDT
Do you have a testcase/site that triggers the leak?
Michael J. Cohen
Comment 4 2006-01-10 08:47:01 PST
simpy scrolling up and down seems to reproduce this for me.
Joost de Valk (AlthA)
Comment 5 2006-02-13 15:55:47 PST
Reassigning to webkit-unassigned, to make sure more people see this.
Joost de Valk (AlthA)
Comment 6 2006-02-15 14:41:57 PST
Comment on attachment 3590 [details] Patch to add ref/deref Though this is an old patch this might yet be valid.
Joost de Valk (AlthA)
Comment 7 2006-02-15 14:42:23 PST
Confirming.
Geoffrey Garen
Comment 8 2006-02-15 15:32:08 PST
Comment on attachment 3590 [details] Patch to add ref/deref Should use a refptr. I'll submit a patch shortly.
Geoffrey Garen
Comment 9 2006-02-15 15:33:58 PST
Created attachment 6514 [details] refptr patch
Eric Seidel (no email)
Comment 10 2006-02-15 15:38:16 PST
Comment on attachment 6514 [details] refptr patch r=me.
Geoffrey Garen
Comment 11 2006-02-15 16:16:49 PST
Landed.
Note You need to log in before you can comment on or make changes to this bug.