WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
4647
Generate JS Bindings should build a build rule
https://bugs.webkit.org/show_bug.cgi?id=4647
Summary
Generate JS Bindings should build a build rule
Eric Seidel (no email)
Reported
2005-08-25 01:29:54 PDT
Generate JS Bindings is the current (hackish) way of generating KDOM's automatic JavaScript bindings. It's a small perl script run as part of the build process. This reallly should be a build rule, keyed off of the idl files included in the project. It also should at least generate the files into the DerivedSources directory, instead of modifying the source root.
Attachments
Replaces build phase with build rule, moves generated files to DerivedSources
(118.32 KB, patch)
2005-08-28 02:40 PDT
,
Eric Seidel (no email)
eric
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2005-08-28 02:40:49 PDT
Created
attachment 3622
[details]
Replaces build phase with build rule, moves generated files to DerivedSources
Eric Seidel (no email)
Comment 2
2005-08-28 02:42:19 PDT
Comment on
attachment 3622
[details]
Replaces build phase with build rule, moves generated files to DerivedSources This turns the previous "Generate JS Bindings" build phase into a really nifty idl -> cpp/h build rule, removes the generated files from the xcode project as well as moves the generated files out of the source root and into DerivedSources.
Darin Adler
Comment 3
2005-08-28 14:38:55 PDT
Comment on
attachment 3622
[details]
Replaces build phase with build rule, moves generated files to DerivedSources Seems good. r=me
Eric Seidel (no email)
Comment 4
2005-08-28 16:19:48 PDT
Comment on
attachment 3622
[details]
Replaces build phase with build rule, moves generated files to DerivedSources It turns out that this only works due to the fact that I had "continue after errors" set, and was building twice (w/o realizing). There are header dependencies in the generated .cpp files which this build rule approach exposes. Until I can find a workaround in Xcode I'm going to need to roll this back out.
Eric Seidel (no email)
Comment 5
2006-06-24 15:04:32 PDT
autobinding is now done as a makefile. Thsi bug is no longer needed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug