Bug 4604 - LEAK -[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:] leaks an ATSUTextLayout
Summary: LEAK -[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePar...
Status: VERIFIED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-23 10:36 PDT by mitz
Modified: 2005-08-23 14:47 PDT (History)
0 users

See Also:


Attachments
proposed patch (673 bytes, patch)
2005-08-23 10:37 PDT, mitz
darin: review+
Details | Formatted Diff | Diff
proposed patch, minus annoying comment (625 bytes, patch)
2005-08-23 10:54 PDT, mitz
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2005-08-23 10:36:02 PDT
-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:] leaks an 
ATSUTextLayout

I noticed it while browsing the code, so no fancy "leaks" output here.
Comment 1 mitz 2005-08-23 10:37:43 PDT
Created attachment 3537 [details]
proposed patch
Comment 2 Darin Adler 2005-08-23 10:46:52 PDT
Comment on attachment 3537 [details]
proposed patch

That comment you copied and pasted really annoys me. Just needed to say that.

Anyway, on your change, r=me!
Comment 3 Darin Adler 2005-08-23 10:47:15 PDT
Need to get this leak fix into Radar too now!
Comment 4 mitz 2005-08-23 10:54:34 PDT
Created attachment 3538 [details]
proposed patch, minus annoying comment
Comment 5 Darin Adler 2005-08-23 14:37:12 PDT
In Radar as <rdar://problem/4228787> ATSUTextLayout leak in 
_ATSU_pointToOffset:style:position:reversed:includePartialGlyphs: (4604).