Bug 4585 – update-webkit doesn't notice when you have SVGSupport and update properly

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Eric Seidel (no email)]

update-webkit doesn't notice when you have SVGSupport and update properly

This is because the current checkout-svg script is sorta a hack.  It checks out SVGSupport separately (as a 
top level module) and creates symlinks from WebCore/ into SVGSupport/

It might be better to change checkout-svg to checkout sub-modules SVGSupport/ksvg2, etc directly into 
the WebCore/ directory...  or at least update update-webkit to test if SVGSupport is checked out and issue 
a cvs up command appopriately.

[Ben La Monica]

Created attachment 3543 [details]
Checks for SVGSupport directory, and updates accordingly

If the SVGSupport directory is present in the webkit dir, then this will also
be updated when update-webkit is run.

[Darin Adler]

Comment on attachment 3543 [details]
Checks for SVGSupport directory, and updates accordingly

Looks fine to me. Using $" seems unnecessarily clever when join could do the
job; it also seems a little ugly to pop the last item off of @sources and then
re-append it.

But this is a small script, and those are nits, so r=me.