Bug 4584 – run-webkit-tests should not print "actual expected diffs" when there are no diffs

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

run-webkit-tests should not print "actual expected diffs" when there are no diffs

Sometimes when using the --pixel tests, there are failures only on the pixel side of things, which still 
causes the resulting failure to print "actual expected diffs" and link to the render dump, even though they 
are all empty.

Furthermore, run-webkit-tests could differentiate between a render tree dump failure and a pixel dump 
failure when printing the -> failed messages (-> failed (pixel) ) , and also could include the percentage 
difference after ->failed (->failed (pixel: 15.5%), etc.)

[Tobias Lidskog]

Created attachment 3516 [details]
don't print layout diffs unless necessary

This is a fix for the first part of this bug (run-webkit-tests should not print
"actual expected diffs" when there are no diffs)

[Tobias Lidskog]

Forgot to mention that the patch also assures that all rows in the result tables have the same number of 
td-cells.

[Darin Adler]

Comment on attachment 3516 [details]
don't print layout diffs unless necessary

Looks like this patch results in two extra cells when $pixelTests is 0. Should
fix that. Otherwise, seems great.

[Tobias Lidskog]

Created attachment 3519 [details]
address darin's comments

[Darin Adler]

Comment on attachment 3519 [details]
address darin's comments

r=me