Bug 4580 - WebCore+SVG asserts when running JavaScript
Summary: WebCore+SVG asserts when running JavaScript
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-22 01:37 PDT by Eric Seidel (no email)
Modified: 2005-08-22 11:18 PDT (History)
0 users

See Also:

Attachments
A simple javascript SVG which asserts (2.32 KB, image/svg+xml)
2005-08-22 01:38 PDT, Eric Seidel (no email) 		no flags Details
Adds necessary Interpreter::lock()/unlock() calls. (1.06 KB, patch)
2005-08-22 02:01 PDT, Eric Seidel (no email) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-08-22 01:37:18 PDT 
As part of recent changes in JSC, more Interpreter::lockCount() asserts were added, thus causing WebCore
+SVG to fail in more places.

Attached is an example SVG which asserts.
Comment 1 Eric Seidel (no email) 2005-08-22 01:38:03 PDT 
Created attachment 3505 [details]
A simple javascript SVG which asserts
Comment 2 Eric Seidel (no email) 2005-08-22 02:01:58 PDT 
Created attachment 3507 [details]
Adds necessary Interpreter::lock()/unlock() calls.
Comment 3 Darin Adler 2005-08-22 08:18:36 PDT 
Comment on attachment 3507 [details]
Adds necessary Interpreter::lock()/unlock() calls.

Looks fine. The APPLE_CHANGES should not be necessary, because the lock/unlock
functions should be empty inlines when locking is not necessary, but I guess
that's not how JavaScriptCore is right now.

r=me