Bug 4574 - HTML parser does not put attributes on the <isindex> element
Summary: HTML parser does not put attributes on the <isindex> element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 4565
  Show dependency tree / graph
 
Reported: 2005-08-21 18:21 PDT by Darin Adler
Modified: 2005-09-04 13:05 PDT (History)
1 user (show)

See Also:

Attachments
patch to put attributes on <isindex> (4.39 KB, patch)
2005-08-21 18:25 PDT, Darin Adler 		mjs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2005-08-21 18:21:13 PDT 
The hack in the HTML parser that implements the <isindex> element does not put the attributes specified 
onto the element it creates.
Comment 1 Darin Adler 2005-08-21 18:25:19 PDT 
Created attachment 3497 [details]
patch to put attributes on <isindex>

This patch fixes the problem by putting the attributes on the <isindex> element
rather than on top level element, but the hack of using the DOM to implement
<isindex> is going to create other problems anyway, so we probably need to do a
better fix. For example, <isindex> doesn't work at all in XHTML.

It seems such a waste to spend any time at all on <isindex>. But this does fix
3 of the W3C tests.
Comment 2 Darin Adler 2005-08-25 10:47:26 PDT 
Obviously the real fix is to add <isindex> support rather than hacking it in the HTML parser.
Comment 3 Darin Adler 2005-08-26 19:56:48 PDT 
Comment on attachment 3497 [details]
patch to put attributes on <isindex>

Maybe we should land this even though it's not the "right" fix.
Comment 4 Maciej Stachowiak 2005-08-28 23:35:52 PDT 
Comment on attachment 3497 [details]
patch to put attributes on <isindex>

Seems fine to do this - the better fix can maybe wait until we have XBL.
Comment 5 Darin Adler 2005-08-30 21:37:16 PDT 
Funny you should say that -- I was thinking Dave would say the same thing.