Bug 4540 - event handlers for all custom events called when any custom event is set
Summary: event handlers for all custom events called when any custom event is set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 4565
  Show dependency tree / graph
 
Reported: 2005-08-20 13:59 PDT by Darin Adler
Modified: 2019-02-06 09:02 PST (History)
2 users (show)

See Also:

Attachments
patch to use AtomicString instead of an integer as an event ID (177.30 KB, patch)
2005-08-20 18:57 PDT, Darin Adler 		mjs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2005-08-20 13:59:48 PDT 
One of the W3C DOM tests exposes the fact that we don't handle custom events propertly. All custom 
events share a single list of event listeners.
Comment 1 Darin Adler 2005-08-20 16:20:04 PDT 
Maciej mentioned that Anders may already be working on this, which is too bad, since I have a patch 
ready!
Comment 2 Darin Adler 2005-08-20 18:57:33 PDT 
Created attachment 3484 [details]
patch to use AtomicString instead of an integer as an event ID

I've done some testing on this, but it still needs its own test for the
layout-tests directory and some performance testing too.
Comment 3 Darin Adler 2005-08-21 17:36:58 PDT 
This is part of the reason that the dispatchEvent12 test in the W3C DOM Level 2 Events suite is failing, but 
there's another reason, described in bug 4570.
Comment 4 Maciej Stachowiak 2005-08-30 02:21:20 PDT 
Great patch! r=me
Comment 5 Lucas Forschler 2019-02-06 09:02:55 PST 
Mass moving XML DOM bugs to the "DOM" Component.