Bug 4437 - clean up error creation with new throwError function
Summary: clean up error creation with new throwError function
Status: VERIFIED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Enhancement
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-14 22:50 PDT by Darin Adler
Modified: 2005-08-15 17:46 PDT (History)
0 users

See Also:


Attachments
adds new throwError function, uses it in every suitable place, other cleanup (141.06 KB, patch)
2005-08-14 22:50 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
adds new throwError function, uses it, other cleanup (merged with TOT) (148.54 KB, patch)
2005-08-14 22:53 PDT, Darin Adler
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2005-08-14 22:50:00 PDT
There are a lot of calls to Error::create followed by calls to exec->setException. I'd like to simplify that 
idiom with a new throwError function.
Comment 1 Darin Adler 2005-08-14 22:50:52 PDT
Created attachment 3393 [details]
adds new throwError function, uses it in every suitable place, other cleanup
Comment 2 Darin Adler 2005-08-14 22:53:42 PDT
Created attachment 3394 [details]
adds new throwError function, uses it, other cleanup (merged with TOT)
Comment 3 Geoffrey Garen 2005-08-15 15:21:51 PDT
Comment on attachment 3394 [details]
adds new throwError function, uses it, other cleanup (merged with TOT)

r=me.