Bug 4420 - make border drawing faster by removing code to alloc/dealloc NSBezierPath
Summary: make border drawing faster by removing code to alloc/dealloc NSBezierPath
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Enhancement
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-13 22:58 PDT by Darin Adler
Modified: 2005-08-14 20:01 PDT (History)
0 users

See Also:

Attachments
patch to use CoreGraphics directly instead of using NSBezierPath (2.99 KB, patch)
2005-08-13 23:00 PDT, Darin Adler 		mjs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2005-08-13 22:58:59 PDT 
There are some borders in the JavaScript iBench that are drawn with bezier path code. The allocation and 
deallocation of NSBezierPath is showing on the profile. We should fix that.
Comment 1 Darin Adler 2005-08-13 23:00:17 PDT 
Created attachment 3368 [details]
patch to use CoreGraphics directly instead of using NSBezierPath
Comment 2 Darin Adler 2005-08-13 23:00:40 PDT 
I measured a 1% improvement on the benchmark with the patch.
Comment 3 Maciej Stachowiak 2005-08-14 02:00:29 PDT 
Comment on attachment 3368 [details]
patch to use CoreGraphics directly instead of using NSBezierPath

CGContextStrokeLineSegments could potentially be even faster than this, at
least when not filling the path.